html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,issue,performed_via_github_app
https://github.com/simonw/datasette/issues/1432#issuecomment-898084675,https://api.github.com/repos/simonw/datasette/issues/1432,898084675,IC_kwDOBm6k_c41h69D,9599,2021-08-13T01:11:30Z,2021-08-13T01:11:30Z,OWNER,It's only `datasette-publish-vercel` that will break the actual functionality - the others will have broken tests.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",969855774,
https://github.com/simonw/datasette/issues/1432#issuecomment-898079507,https://api.github.com/repos/simonw/datasette/issues/1432,898079507,IC_kwDOBm6k_c41h5sT,9599,2021-08-13T01:08:42Z,2021-08-13T01:09:41Z,OWNER,"This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=%21datasette%2F**

> ### datasette-cluster-map/tests/test_cluster_map.py
> 
> @pytest.mark.asyncio
> 
> async def test_respects_base_url():
> ds = Datasette([], memory=True, config={""base_url"": ""/foo/""})
> response = await ds.client.get(""/:memory:?sql=select+1+as+latitude,+2+as+longitude"")
> assert (
> 
> ### datasette-export-notebook/tests/test_export_notebook.py
> 
> @pytest.mark.asyncio
> 
> async def test_notebook_no_csv(db_path):
> datasette = Datasette([db_path], config={""allow_csv_stream"": False})
> response = await datasette.client.get(""/db/big.Notebook"")
> assert "".csv"" not in response.text
> 
> ### datasette-publish-vercel/tests/test_publish_vercel.py
> metadata=metadata,
> cors=True,
> config={""default_page_size"": 10, ""sql_time_limit_ms"": 2000}
> ).app()
> """"""
> 
> ### datasette-publish-vercel/datasette_publish_vercel/__init__.py
> metadata=metadata{extras},
> cors=True,
> config={settings}
> 
> ).app()
> 
> """""".strip()
> 
> ### datasette-search-all/tests/test_search_all.py
> 
> async def test_base_url(db_path, path):
> sqlite_utils.Database(db_path)[""creatures""].enable_fts([""name"", ""description""])
> datasette = Datasette([db_path], config={""base_url"": ""/foo/""})
> response = await datasette.client.get(path)
> assert response.status_code == 200

I should fix those as soon as this goes out in a release. I won't close this issue until then.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",969855774,
https://github.com/simonw/datasette/issues/1432#issuecomment-898074849,https://api.github.com/repos/simonw/datasette/issues/1432,898074849,IC_kwDOBm6k_c41h4jh,9599,2021-08-13T01:03:40Z,2021-08-13T01:03:40Z,OWNER,"Also this method: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/app.py#L422-L424

And the places that use it:

https://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/base.py#L617

https://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/database.py#L459

Which is used in this template: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/templates/table.html#L204

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",969855774,