home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1012504251

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1591#issuecomment-1012504251 https://api.github.com/repos/simonw/datasette/issues/1591 1012504251 IC_kwDOBm6k_c48WZa7 9599 2022-01-13T20:49:19Z 2022-01-13T20:49:59Z OWNER

I try to stick pretty closely to what Click supports, and Click likes you to define options explicitly so that it can display them in the output of --help.

But... that makes me think that actually showing these options in --help is likely a better idea. My --plugin-setting concept would have help that looks something like this: % datasette serve --help ... --plugin-setting <TEXT TEXT TEXT>... Setting for a specified plugin. That's not great help!

The alternative would be to allow plugins to register their extra options with the command - which would mean the help output could look like this instead: % datasette serve --help ... --tiddlywiki-db <TEXT> Name of database to use for datasette-tiddlywiki This feels like a good argument to me for plugins to explicitly register their settings. I'm not sure if I should enforce the name-of-plugin- prefix, or if I should allow plugins to define any setting they like. I'm still nervous about plugins over-riding existing or future default options to that command.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1100015398  
Powered by Datasette · Queries took 1.141ms · About: github-to-sqlite