home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1029306428

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029306428 https://api.github.com/repos/simonw/sqlite-utils/issues/385 1029306428 IC_kwDOCGYnMM49Wfg8 25778 2022-02-03T19:03:43Z 2022-02-03T19:03:43Z CONTRIBUTOR

I thought about adding these as methods on Database and Table, and I'm back and forth on it for the same reasons you are. It's certainly cleaner, and it's clearer what you're operating on. I could go either way.

I do sort of like having all the Spatialite stuff in its own module, just because it's built around an extension you might not have or want, but I don't know if that's a good reason to have a different API.

You could have init_spatialite add methods to Database and Table, so they're only there if you have Spatialite set up. Is that too clever? It feels too clever.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1102899312  
Powered by Datasette · Queries took 1.826ms · About: github-to-sqlite