home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1073073547

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1668#issuecomment-1073073547 https://api.github.com/repos/simonw/datasette/issues/1668 1073073547 IC_kwDOBm6k_c4_9c2L 9599 2022-03-19T20:06:07Z 2022-03-19T20:06:07Z OWNER

Implementing this is a little tricky because there's a whole lot of code that expects the database captured by the URL routing to be the name used to look up the database in datasette.databases - or via .get_database().

The DataView.get() method is a good example of the trickyness here. It even has code that dispatches out to plugin hooks that take database as a parameter.

https://github.com/simonw/datasette/blob/61419388c134001118aaf7dfb913562d467d7913/datasette/views/base.py#L383-L555

All the more reason to get rid of that BaseView -> DataView -> TableView hierarchy entirely: - #1660

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1174306154  
Powered by Datasette · Queries took 1.724ms · About: github-to-sqlite