home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1254032378

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/488#issuecomment-1254032378 https://api.github.com/repos/simonw/sqlite-utils/issues/488 1254032378 IC_kwDOCGYnMM5KvwP6 9599 2022-09-21T17:47:54Z 2022-09-21T17:47:54Z OWNER

New tests should go in: https://github.com/simonw/sqlite-utils/blob/main/tests/test_transform.py

I think the implementation fix needs to go near here: https://github.com/simonw/sqlite-utils/blob/0b315d3fa83c1584eaeec32f24912898621e437a/sqlite_utils/db.py#L1770-L1775

The trick is going to be teaching that generated SQL to know which columns are integer or float and to convert "" to null as part of that operation.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1373224657  
Powered by Datasette · Queries took 1.077ms · About: github-to-sqlite