home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1256659788

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1817#issuecomment-1256659788 https://api.github.com/repos/simonw/datasette/issues/1817 1256659788 IC_kwDOBm6k_c5K5xtM 9599 2022-09-23T20:49:22Z 2022-09-23T20:49:22Z OWNER

Implementation challenge: all four of those hooks are called inside the datasette.render_template() method, which has this signature:

https://github.com/simonw/datasette/blob/cb1e093fd361b758120aefc1a444df02462389a3/datasette/app.py#L945-L947

So I would have to pull the sql and params variables out of the context since they are not being passed to that method. OR I could teach that method to take those as optional arguments.

Might be an opportunity to clean up this hack:

https://github.com/simonw/datasette/blob/cb1e093fd361b758120aefc1a444df02462389a3/datasette/app.py#L959-L964

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1384273985  
Powered by Datasette · Queries took 0.997ms · About: github-to-sqlite