issue_comments: 1256662785

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1817#issuecomment-1256662785 https://api.github.com/repos/simonw/datasette/issues/1817 1256662785 IC_kwDOBm6k_c5K5ycB 9599 2022-09-23T20:53:21Z 2022-09-23T20:53:21Z OWNER

Maybe the signature for that method should be:

python async def render_template( self, templates, context=None, plugin_context=None, request=None, view_name=None ): Where plugin_context is a special dictionary of values that can be passed through to plugin hooks that accept them - so database, table, columns, sql and params.

Those would then be passed when specific views call render_template() - which they currently do via calling BaseView.render(...), but actually the views that are used for tables and queries don't even call that directly due to the weird designed used with DataView subclasses that implement a .data() method.

So yet another change that's blocked on fixing that long-running weird piece of technical debt: - https://github.com/simonw/datasette/issues/1518

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1384273985