issue_comments: 1343872168

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1939#issuecomment-1343872168 https://api.github.com/repos/simonw/datasette/issues/1939 1343872168 IC_kwDOBm6k_c5QGdyo 9599 2022-12-09T05:29:53Z 2022-12-09T05:29:53Z OWNER

I'm going to address those ideas for changes to the permission_allowed() in a separate issue.

What would it take for the register_permissions() hook to be something I'm comfortable landing?

I think it's mainly that the list of permissions it provides should Do More Stuff:

  • Participate in unit tests, in particular this one:

https://github.com/simonw/datasette/blob/e539c1c024bc62d88df91d9107cbe37e7f0fe55f/tests/conftest.py#L79-L102

  • That new default option should be respected - maybe if you omit default= from a call to permission_allowed() it could fall back on the default from there?
  • Log a warning if you attempt to check a permission that wasn't registered

Then I can use the permissions - in particular their metadata - to help implement his:

  • 1636

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1485757511