home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1606270055

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/pull/560#issuecomment-1606270055 https://api.github.com/repos/simonw/sqlite-utils/issues/560 1606270055 IC_kwDOCGYnMM5fvbxn 9599 2023-06-25T21:31:56Z 2023-06-25T21:31:56Z OWNER

Lots of failures now that I'm trying to run the tests against sqlean.py on macOS and Python 3.10: https://github.com/simonw/sqlite-utils/actions/runs/5371800108/jobs/9744802953

A bunch of these, because pysqlite3 chooses not to implement .iterdump(): ``` @pytest.fixture def db_to_analyze_path(db_to_analyze, tmpdir): path = str(tmpdir / "test.db") db = sqlite3.connect(path)

  db.executescript("\n".join(db_to_analyze.conn.iterdump()))

E AttributeError: 'sqlean.dbapi2.Connection' object has no attribute 'iterdump' Also some of these: def test_analyze_whole_database(db): assert set(db.table_names()) == {"one_index", "two_indexes"} db.analyze() assert set(db.table_names()) == {"one_index", "two_indexes", "sqlite_stat1"} E AssertionError: assert {'one_index',...'two_indexes'} == {'one_index',...'two_indexes'} E Extra items in the left set: E 'sqlite_stat4' E Full diff: E - {'two_indexes', 'sqlite_stat1', 'one_index'} E + {'two_indexes', 'sqlite_stat1', 'sqlite_stat4', 'one_index'} E ? ++++++++++++++++ `` Apparentlysqlean.pyadds asqlite_stat4` table that the tests are not expecting.

Plus some errors that look like this: ``` def test_enable_wal(): runner = CliRunner() dbs = ["test.db", "test2.db"] with runner.isolated_filesystem(): for dbname in dbs: db = Database(dbname) db["t"].create({"pk": int}, pk="pk") assert db.journal_mode == "delete" result = runner.invoke(cli.cli, ["enable-wal"] + dbs)

      assert 0 == result.exit_code

E AssertionError: assert 0 == 1 E + where 1 = <Result OperationalError('cannot change into wal mode from within a transaction')>.exit_code Test summary: ============ 13 failed, 909 passed, 16 skipped, 2 errors in 19.29s ============= ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1773458985  
Powered by Datasette · Queries took 1.788ms · About: github-to-sqlite