issue_comments: 1668687891

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/2118#issuecomment-1668687891 https://api.github.com/repos/simonw/datasette/issues/2118 1668687891 IC_kwDOBm6k_c5jdigT 9599 2023-08-07T23:11:04Z 2023-08-07T23:14:34Z OWNER

One of the failing tests is because this URL on my local environment returns this:

http://127.0.0.1:8001/_memory.json?sql=select+blah json {"rows": [], "columns": [], "truncated": false} With a 200 status code. It should be an error.

https://latest.datasette.io/_memory.json?sql=select+blah returns a 400 status code with the following JSON:

json { "ok": false, "database": "_memory", "query_name": null, "rows": [], "truncated": false, "columns": [], "query": { "sql": "select blah", "params": {} }, "error": "no such column: blah", "private": false, "allow_execute_sql": true, "query_ms": 2.68310698447749, "source": "tests/fixtures.py", "source_url": "https://github.com/simonw/datasette/blob/main/tests/fixtures.py", "license": "Apache License 2.0", "license_url": "https://github.com/simonw/datasette/blob/main/LICENSE" } So I need a design for what this should look like for the error case.

I should consider what errors look like for alternative formats too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1823352380