issue_comments: 389894382

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/266#issuecomment-389894382 https://api.github.com/repos/simonw/datasette/issues/266 389894382 MDEyOklzc3VlQ29tbWVudDM4OTg5NDM4Mg== 9599 2018-05-17T14:51:13Z 2018-05-17T14:53:23Z OWNER

I should definitely sanity check if the _next= route really is the most efficient way to build this. It may turn out that iterating over a SQLite cursor with a million rows in it is super-efficient and would provide much more reliable performance (plus solve the problem for retrieving full custom SQL queries where we can't do keyset pagination).

Problem here is that we run SQL queries in a thread pool. A query that returns millions of rows would presumably tie up a SQL thread until it has finished, which could block the server. This may be a reason to stick with _next= keyset pagination - since it ensures each SQL thread yields back again after each 1,000 rows.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 323681589