issue_comments: 440128762

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/389#issuecomment-440128762 https://api.github.com/repos/simonw/datasette/issues/389 440128762 MDEyOklzc3VlQ29tbWVudDQ0MDEyODc2Mg== 9599 2018-11-20T03:52:11Z 2018-11-20T03:52:11Z OWNER

The problem is Sanic. Here's the error I'm getting:

``` (venv) datasette $ pytest -x ============================================================= test session starts ============================================================== platform darwin -- Python 3.7.1, pytest-4.0.0, py-1.7.0, pluggy-0.8.0 rootdir: /Users/simonw/Dropbox/Development/datasette, inifile: collected 258 items

tests/test_api.py ...................F

=================================================================== FAILURES =================================================================== _________ test_table_with_slashes_in_name ____________

app_client = <tests.fixtures.TestClient object at 0x10ada7d68>

def test_table_with_slashes_in_name(app_client):
    response = app_client.get('/fixtures/table%2Fwith%2Fslashes.csv?_shape=objects&_format=json')

  assert response.status == 200

E AssertionError: assert 404 == 200 ```

That's because something about how Sanic handles escape characters in URLs changed between 0.7.0 and 0.8.3.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 382471625