home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 473724868

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/418#issuecomment-473724868 https://api.github.com/repos/simonw/datasette/issues/418 473724868 MDEyOklzc3VlQ29tbWVudDQ3MzcyNDg2OA== 9599 2019-03-17T23:07:31Z 2019-03-17T23:07:31Z OWNER

The design of this feature is discussed extensively in the comments on pull request #416

Some demos:

  • https://latest.datasette.io/fixtures/facetable now no longer redirects to the hash
  • https://latest.datasette.io/fixtures/facetable?_hash=1 redirects to https://latest.datasette.io/fixtures-dd88475/facetable

``` ~ $ curl -i 'https://latest.datasette.io/fixtures-dd88475/facetable' HTTP/2 200 date: Sun, 17 Mar 2019 23:05:21 GMT content-type: text/html; charset=utf-8 content-length: 17555 cache-control: max-age=31536000

</html>~ $ curl -i 'https://latest.datasette.io/fixtures/facetable' HTTP/2 200 date: Sun, 17 Mar 2019 23:05:40 GMT content-type: text/html; charset=utf-8 content-length: 17410 cache-control: max-age=5 ```

There are now three config settings relevant to the above:

default_cache_ttl - defaults to 5s. The default cache TTL for non-hashed resources. default_cache_ttl_hashed - defaults to 31536000s. The default cache TTL for hashed resources. hash_urls - defaults to False. If True, all URLs will attempt to redirect to their hashed version.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
421548881  
Powered by Datasette · Queries took 1.026ms · About: github-to-sqlite