issue_comments: 484694648

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/434#issuecomment-484694648 https://api.github.com/repos/simonw/datasette/issues/434 484694648 MDEyOklzc3VlQ29tbWVudDQ4NDY5NDY0OA== 9599 2019-04-18T21:23:56Z 2019-04-18T21:23:56Z OWNER

Thanks for looking into this!

To clarify: currently, the Dockerfile that we generate looks something like this:

CMD ["datasette", "serve", "--host", "0.0.0.0", "fixtures.db", "--cors", "--port", "8001"]

Your code here changes that CMD line to look like this instead, in order to set the port based on an environment variable:

CMD ["sh", "-c", "datasette serve --port $PORT ..."]

I wonder if this is the only way to do this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 434321685