issue_comments: 484699119

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/434#issuecomment-484699119 https://api.github.com/repos/simonw/datasette/issues/434 484699119 MDEyOklzc3VlQ29tbWVudDQ4NDY5OTExOQ== 9599 2019-04-18T21:40:45Z 2019-04-18T21:40:45Z OWNER

I asked @andrewgodwin about this and he confirmed that if we want to read an environment variable we can't use the CMD [...] syntax in the way that we were using it.

He did suggest that if we're doing CMD ["sh", "-c", "datasette serve --port $PORT ..."] we may as well do this instead:

CMD "datasette serve --port $PORT ..."

We should apply some command-line escaping here - if the user passes --version-note=hello$there to datasette publish we need that $ not to be accidentally evaluated as an environment variable.

It looks like shlex.quote is the right way to do that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 434321685