home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 489209255

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/446#issuecomment-489209255 https://api.github.com/repos/simonw/datasette/issues/446 489209255 MDEyOklzc3VlQ29tbWVudDQ4OTIwOTI1NQ== 9599 2019-05-03T19:15:23Z 2019-05-03T19:16:34Z OWNER

The register_output_renderer() hook currently returns a dictionary with body, content_type and status_code keys but each of these keys are optionaly. I'm tempted to make all three required to better fit this model - @russss any objections?

Alternative would be to support default values for properties of the DataSpec subclass - maybe:

__defaults__ = {"body": "", "content_type": "text/plain", "status_code": 200}

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
440134714  
Powered by Datasette · Queries took 1.09ms · About: github-to-sqlite