home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 512930353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/537#issuecomment-512930353 https://api.github.com/repos/simonw/datasette/issues/537 512930353 MDEyOklzc3VlQ29tbWVudDUxMjkzMDM1Mw== 14834132 2019-07-18T18:20:53Z 2019-07-18T18:34:03Z NONE

Ok great, getting the __qualname__ to be TableView and adding endpoint to the scope in AsgiRouter is simple enough (already done). However, (unless I'm missing a plugin hook or something) the suggestion of utilising it within a datasette-sentry plugin may not work. The only hook that would have access to the scope is the asgi_wrapper hook. But as this wraps the existing asgi app, the endpoint won't yet have been added to the scope received by the hook https://github.com/SteadBytes/datasette/blob/107d47567dedd472eebec7f35bc34f5b58285ba8/datasette/app.py#L672 . However, I'm not sure where else the endpoint could be added to the asgi scope :thinking:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
463544206  
Powered by Datasette · Queries took 0.911ms · About: github-to-sqlite