issue_comments: 589908912

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/675#issuecomment-589908912 https://api.github.com/repos/simonw/datasette/issues/675 589908912 MDEyOklzc3VlQ29tbWVudDU4OTkwODkxMg== 9599 2020-02-22T02:38:21Z 2020-02-22T02:38:21Z OWNER

Interesting feature suggestion.

My initial instinct was that this would be better handled using the layered nature of Docker - so build a Docker image with datasette package and then have a separate custom script which takes that image, copies in the extra data and outputs a new image.

But... datasette package is already meant to be more convenient than messing around with Docker by hand like this - so actually having a --copy option like you describe here feels like it's within scope of what datasette package is meant to do.

So yeah - if you're happy to design this I think it would be worth us adding.

Small design suggestion: allow --copy to be applied multiple times, so you can do something like this:

datasette package \
    --copy ~/project/templates /templates \
    --copy ~/project/README.md /README.md \
    data.db

Also since Click arguments can take multiple options I don't think you need to have the : in there - although if it better matches Docker's own UI it might be more consistent to have it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 567902704