home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 590598689

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/683#issuecomment-590598689 https://api.github.com/repos/simonw/datasette/issues/683 590598689 MDEyOklzc3VlQ29tbWVudDU5MDU5ODY4OQ== 9599 2020-02-24T23:20:11Z 2020-02-24T23:20:11Z OWNER

I think if block it makes sense to return the return value of the function that was executed. Without it all I really need to do is return the uuid so something could theoretically poll for completion later on.

But is it weird having a function that returns different types depending on if you passed block=True or not? Should they be differently named functions?

I'm OK with the block=True pattern changing the return value I think.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
570101428  
Powered by Datasette · Queries took 1.0ms · About: github-to-sqlite