issue_comments: 638249652

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/796#issuecomment-638249652 https://api.github.com/repos/simonw/datasette/issues/796 638249652 MDEyOklzc3VlQ29tbWVudDYzODI0OTY1Mg== 9599 2020-06-03T14:51:29Z 2020-06-03T14:51:51Z OWNER

Consider this one: "delete_name": { "sql": "delete from names where rowid = :rowid", "write": True, "on_success_message": "Name deleted", }, If the user enters an invalid rowid the query will still execute without errors and hence the success message will still be displayed. Can I address this?

Maybe allow an optional "rowcount_expected": 1 property? And if that count isn't matched treat the query as an error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 629595228