home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 639269559

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/798#issuecomment-639269559 https://api.github.com/repos/simonw/datasette/issues/798 639269559 MDEyOklzc3VlQ29tbWVudDYzOTI2OTU1OQ== 9599 2020-06-05T05:34:56Z 2020-06-05T05:35:23Z OWNER

I don't want to set a cookie on a page response that is being cached.

Right now the ASGI middleware will be doing exactly that, which is bad.

But how do I get certainty that when you load a page with a form that will be CSRF protected you have been served the cookie?

Maybe those pages should do something explicit to the request object indicating that the cookie is needed?

That works for Datasette (since it has mutable request objects) but I'm not sure how it would work in the asgi-csrf pure ASGI middleware context.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
631300342  
Powered by Datasette · Queries took 1.374ms · About: github-to-sqlite