home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 672338113

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/926#issuecomment-672338113 https://api.github.com/repos/simonw/datasette/issues/926 672338113 MDEyOklzc3VlQ29tbWVudDY3MjMzODExMw== 9599 2020-08-11T22:57:28Z 2020-08-11T22:57:28Z OWNER

I partly want this so I can easily implement a better test method for the Homebrew package. The test I have right now looks like this:

https://github.com/simonw/homebrew-datasette/blob/8aa30aa183158051a987a7e3f50e7e3ee05d8ee9/Formula/datasette.rb#L125-L127

test do system bin/"datasette", "--help" end The Homebrew docs at https://docs.brew.sh/Formula-Cookbook#add-a-test-to-the-formula say:

We want tests that don't require any user input and test the basic functionality of the application. For example foo build-foo input.foo is a good test and (despite their widespread use) foo --version and foo --help are bad tests. However, a bad test is better than no test at all.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
677250834  
Powered by Datasette · Queries took 1.167ms · About: github-to-sqlite