home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 714289680

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1031#issuecomment-714289680 https://api.github.com/repos/simonw/datasette/issues/1031 714289680 MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA== 299380 2020-10-22T07:23:52Z 2020-10-22T07:23:52Z NONE

The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation.

The reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
724369025  
Powered by Datasette · Queries took 1.2ms · About: github-to-sqlite