home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 715643646

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1042#issuecomment-715643646 https://api.github.com/repos/simonw/datasette/issues/1042 715643646 MDEyOklzc3VlQ29tbWVudDcxNTY0MzY0Ng== 9599 2020-10-24T00:33:46Z 2020-10-24T00:33:46Z OWNER

I'd like to do this all in the datasette.render_template() method to ensure it's available to plugins as well, not just core code that uses the BaseView class.

This code is the problem: https://github.com/simonw/datasette/blob/d3e9b0aecb6f8e9b2befd9c654ccb7ce852db3e7/datasette/views/base.py#L114-L133

I think I'll fix this by moving the select_templates mechanism into datasette.render_templates().

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
727802081  
Powered by Datasette · Queries took 2.605ms · About: github-to-sqlite