issue_comments: 808647937

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1272#issuecomment-808647937 https://api.github.com/repos/simonw/datasette/issues/1272 808647937 MDEyOklzc3VlQ29tbWVudDgwODY0NzkzNw== 9599 2021-03-27T04:23:19Z 2021-03-27T04:23:36Z OWNER

Part of the challenge here is only running if a Docker daemon is available. I think this pattern works, in tests/test_dockerfile.py: ```python import httpx import pathlib import pytest import subprocess

root = pathlib.Path(file).parent.parent

def docker_is_available(): try: client = httpx.Client( transport=httpx.HTTPTransport(uds="/var/run/docker.sock") ) client.get("http://docker/info") return True except httpx.ConnectError: return False

@pytest.fixture def build_container(): assert (root / "Dockerfile").exists() subprocess.check_call([ "docker", "build", str(root), "-t", "datasette-dockerfile-test" ])

@pytest.mark.skipif(not docker_is_available(), reason="Docker is not available" ) def test_dockerfile(build_container): output = subprocess.check_output([ "docker", "run", "datasette-dockerfile-test", "datasette", "--get", "/_memory?sql=select+1&shape=_array" ]) assert False, "Implement better assertion here" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 838245338