home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 880150755

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/268#issuecomment-880150755 https://api.github.com/repos/simonw/datasette/issues/268 880150755 MDEyOklzc3VlQ29tbWVudDg4MDE1MDc1NQ== 9599 2021-07-14T19:26:47Z 2021-07-14T19:29:08Z OWNER

What are the side-effects of turning that on in the query string, or even by default as you suggested? I see that you stated in the docs... "to ensure they do not cause any confusion for users who are not aware of them", but I'm not sure what those could be.

Mainly that it's possible to generate SQL queries that crash with an error. This was the example that convinced me to default to escaping:

  • https://www.niche-museums.com/browse/museums?_search=park.&_searchmode=raw (returns fts5: syntax error near ".")
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
323718842  
Powered by Datasette · Queries took 1.378ms · About: github-to-sqlite