home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 982235541

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1527#issuecomment-982235541 https://api.github.com/repos/simonw/datasette/issues/1527 982235541 IC_kwDOBm6k_c46i7mV 9599 2021-11-30T02:57:34Z 2021-11-30T02:58:44Z OWNER

I started fiddling with a test for this which extracts the <select> options and ALL of the <input> fields, but I probably won't use it: python def test_exact_parameter_results_in_correct_hidden_fields(app_client): # https://github.com/simonw/datasette/issues/1527 response = app_client.get( "/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown" ) # In this case we should NOT have a hidden _neighborhood__exact=Downtown field form = Soup(response.body, "html.parser").find("form") selects = [ { "name": select["name"], "value": select.select("option[selected]")[0].text if select.select("option[selected]") else "", } for select in form.findAll("select") ] inputs = [input.attrs for input in form.findAll("input")] # Turn those both into a {name: (value, type)} array form_inputs = {} form_inputs.update( {select["name"]: (select["value"], "select") for select in selects} ) form_inputs.update( { input["name"]: (input.get("value"), input["type"]) for input in inputs if input.get("name") } ) assert form_inputs == { "_filter_column_1": ("_neighborhood", "select"), "_filter_op_1": ("=", "select"), "_filter_value_1": ("Downtown", "text"), "_filter_column": ("", "select"), "_filter_op": ("", "select"), "_filter_value": (None, "text"), "_sort": ("Sort by pk", "select"), "_sort_by_desc": (None, "checkbox"), "_facet": ("_neighborhood", "hidden"), "_neighborhood__exact": ("Downtown", "hidden"), } The problem is that last hidden field, _neighborhood__exact=Downtown - which should not be there.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1059555791  
Powered by Datasette · Queries took 1.09ms · About: github-to-sqlite