home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 997127784

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1561#issuecomment-997127784 https://api.github.com/repos/simonw/datasette/issues/1561 997127784 IC_kwDOBm6k_c47bvZo 9599 2021-12-18T02:27:56Z 2021-12-18T02:27:56Z OWNER

Oh that's an interesting solution, combining the hashes of all of the individual databases.

I'm actually not a big fan of hashed_url mode - I implemented it right at the start of the project because it felt like a clever hack, and then ended up making it not-the-default a few years ago:

  • 418

  • 419

  • 421

I've since not found myself wanting to use it at all for any of my projects - which makes me nervous, because it means there's a pretty complex feature that I'm not using at all, so it's only really protected by the existing unit tests for it.

What I'd really like to do is figure out how to have hashed URL mode work entirely as a plugin - then I could extract it from Datasette core entirely (which would simplify a bunch of stuff) but people who find the optimization useful would be able to access it.

I'm not sure that the existing plugin hooks are robust enough to do that yet though.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1082765654  
Powered by Datasette · Queries took 0.785ms · About: github-to-sqlite