issue_comments: 997462604

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1545#issuecomment-997462604 https://api.github.com/repos/simonw/datasette/issues/1545 997462604 IC_kwDOBm6k_c47dBJM 9599 2021-12-19T21:17:08Z 2021-12-19T21:17:08Z OWNER

Here's the relevant code: https://github.com/simonw/datasette/blob/4094741c2881c2ada3f3f878b532fdaec7914953/datasette/app.py#L1204-L1219

It's using route_path.split("/") which should be OK because that's the incoming request.path path - which I would expect to use / even on Windows. Then it uses os.path.join which should do the right thing.

I need to get myself a proper Windows development environment setup to investigate this one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1075893249