issue_comments: 997496626

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/356#issuecomment-997496626 https://api.github.com/repos/simonw/sqlite-utils/issues/356 997496626 IC_kwDOCGYnMM47dJcy 9599 2021-12-20T00:38:15Z 2022-01-06T01:29:03Z OWNER

The implementation of this gets a tiny bit complicated.

Ignoring --convert, the --lines option can internally produce {"line": ...} records and the --all option can produce {"all": ...} records.

But... when --convert is used, what should the code run against?

It could run against those already-converted records but that's a little bit strange, since you'd have to do this:

sqlite-utils insert blah.db blah myfile.txt --all --convert '{"item": s for s in value["all"].split("-")}'

Having to use value["all"] there is unintuitive. It would be nicer to have a all variable to work against.

But then for --lines should the local variable be called line? And how best to summarize these different names for local variables in the inline help for the feature?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1077431957