issue_comments

Table actions

11 rows where author_association = "CONTRIBUTOR" and user = 2657547 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • rixx · 11 ✖

author_association 1

  • CONTRIBUTOR · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
632555800 https://github.com/simonw/datasette/issues/767#issuecomment-632555800 https://api.github.com/repos/simonw/datasette/issues/767 MDEyOklzc3VlQ29tbWVudDYzMjU1NTgwMA== rixx 2657547 2020-05-22T08:00:23Z 2020-05-22T08:00:23Z CONTRIBUTOR

That would be perfect!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow to specify a URL fragment for canned queries 620969465  
549246007 https://github.com/simonw/datasette/pull/602#issuecomment-549246007 https://api.github.com/repos/simonw/datasette/issues/602 MDEyOklzc3VlQ29tbWVudDU0OTI0NjAwNw== rixx 2657547 2019-11-04T07:29:33Z 2019-11-04T07:29:33Z CONTRIBUTOR

Not sure – I'm always a bit weirded out when elements that I clicked disappear on me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Offer to format readonly SQL 509535510  
544214418 https://github.com/simonw/datasette/pull/601#issuecomment-544214418 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDIxNDQxOA== rixx 2657547 2019-10-20T02:29:49Z 2019-10-20T02:29:49Z CONTRIBUTOR

Submitted in #602!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
544008944 https://github.com/simonw/datasette/pull/601#issuecomment-544008944 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDAwODk0NA== rixx 2657547 2019-10-18T23:40:48Z 2019-10-18T23:40:48Z CONTRIBUTOR

The only negative impact that comes to mind is that now you have no way to get the read-only query to be formatted nicely, I think, so maybe a second PR adding the formatting functionality even to the read-only page would be good?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
544008463 https://github.com/simonw/datasette/pull/601#issuecomment-544008463 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDAwODQ2Mw== rixx 2657547 2019-10-18T23:39:21Z 2019-10-18T23:39:21Z CONTRIBUTOR

That looks right, and I completely agree with the intent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
541587823 https://github.com/simonw/datasette/pull/590#issuecomment-541587823 https://api.github.com/repos/simonw/datasette/issues/590 MDEyOklzc3VlQ29tbWVudDU0MTU4NzgyMw== rixx 2657547 2019-10-14T09:58:23Z 2019-10-14T09:58:23Z CONTRIBUTOR

Added tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Handle spaces in DB names 505818256  
541562581 https://github.com/simonw/datasette/pull/590#issuecomment-541562581 https://api.github.com/repos/simonw/datasette/issues/590 MDEyOklzc3VlQ29tbWVudDU0MTU2MjU4MQ== rixx 2657547 2019-10-14T08:57:46Z 2019-10-14T08:57:46Z CONTRIBUTOR

Ah, thank you – I saw the need for unit tests but wasn't sure what the best way to add one would be.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Handle spaces in DB names 505818256  
541119038 https://github.com/simonw/datasette/issues/512#issuecomment-541119038 https://api.github.com/repos/simonw/datasette/issues/512 MDEyOklzc3VlQ29tbWVudDU0MTExOTAzOA== rixx 2657547 2019-10-11T15:49:13Z 2019-10-11T15:49:13Z CONTRIBUTOR

How open are you to changing the config variable names (with appropriate deprecation, of course)? "about_url_text", "license_url_text" etc might be better suited to convey that these are just meant as basically URL titles.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "about" parameter in metadata does not appear when alone 457147936  
541118904 https://github.com/simonw/datasette/issues/507#issuecomment-541118904 https://api.github.com/repos/simonw/datasette/issues/507 MDEyOklzc3VlQ29tbWVudDU0MTExODkwNA== rixx 2657547 2019-10-11T15:48:49Z 2019-10-11T15:48:49Z CONTRIBUTOR

Headless Chrome and Firefox via Selenium are a solid choice in my experience. You may be interested in how pretix and pretalx solve this problem: They use pytest to create those screenshots on release to make sure they are up to date. See this writeup and this repo.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Every datasette plugin on the ecosystem page should have a screenshot 455852801  
541052329 https://github.com/simonw/datasette/issues/585#issuecomment-541052329 https://api.github.com/repos/simonw/datasette/issues/585 MDEyOklzc3VlQ29tbWVudDU0MTA1MjMyOQ== rixx 2657547 2019-10-11T12:53:51Z 2019-10-11T12:53:51Z CONTRIBUTOR

I think this would be good, yeah – currently, databases are explicitly sorted by name in the IndexView, we could just remove that part (and use an OrderedDict for consistency, I suppose)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Databases on index page should display in order they were passed to "datasette serve"? 503217375  
504809397 https://github.com/simonw/datasette/issues/523#issuecomment-504809397 https://api.github.com/repos/simonw/datasette/issues/523 MDEyOklzc3VlQ29tbWVudDUwNDgwOTM5Nw== rixx 2657547 2019-06-24T01:38:14Z 2019-06-24T01:38:14Z CONTRIBUTOR

Ah, apologies – I had found and read those issues, but I was under the impression that they refered only to the filtered row count, not the unfiltered total row count.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show total/unfiltered row count when filtering 459627549  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);