issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and user = 50527 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • jefftriplett · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1256781274 https://github.com/simonw/datasette/issues/1817#issuecomment-1256781274 https://api.github.com/repos/simonw/datasette/issues/1817 IC_kwDOBm6k_c5K6PXa jefftriplett 50527 2022-09-23T22:59:46Z 2022-09-23T22:59:46Z CONTRIBUTOR

While you are adding features, would you be future-proofing your APIs if you switched over some arguments over to keyword-only arguments or would that be too disruptive?

Thinking out loud:

async def render_template( self, templates, *, context=None, plugin_context=None, request=None, view_name=None ):

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Expose `sql` and `params` arguments to various plugin hooks 1384273985  
1224382336 https://github.com/simonw/sqlite-utils/issues/467#issuecomment-1224382336 https://api.github.com/repos/simonw/sqlite-utils/issues/467 IC_kwDOCGYnMM5I-peA jefftriplett 50527 2022-08-23T17:16:13Z 2022-08-23T17:16:13Z CONTRIBUTOR

Should passing alter=True also drop any columns that aren't included in the new table structure?

It could even spot column types that aren't correct and fix those.

Is that consistent with the expectations set by how alter=True works elsewhere?

I would lean towards not dropping them (or making a drop=True or drop_columns=Trueor drop_missing_columns=True) to work with existing tables easier.

I do like that sqlite-utils mostly just works with existing tables but it's also nice to add to existing fields in a few cases. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for ensuring a table has all the columns 1348169997  
748305976 https://github.com/simonw/datasette/issues/493#issuecomment-748305976 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDc0ODMwNTk3Ng== jefftriplett 50527 2020-12-18T20:34:39Z 2020-12-18T20:34:39Z CONTRIBUTOR

I can't keep up with the renaming contexts, but I like having the ability to run datasette+ datasette-ripgrep against different configs:

shell datasette serve --metadata=./metadata.json

I have one for all of my code and one per client who has lots of code. So as long as I can point to datasette to something, it's easy to work with. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
735281577 https://github.com/simonw/datasette/issues/493#issuecomment-735281577 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDczNTI4MTU3Nw== jefftriplett 50527 2020-11-28T19:39:53Z 2020-11-28T19:39:53Z CONTRIBUTOR

I was confused by --config and I tried passing the json from datasette-ripgrep into config.json just as a wild guess.

A short term solution might be pointing out in plugins that their snippet json can go in metadata.json at least makes it easier to search for config options or to know where to start if someone is new. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
735279355 https://github.com/simonw/datasette/pull/1112#issuecomment-735279355 https://api.github.com/repos/simonw/datasette/issues/1112 MDEyOklzc3VlQ29tbWVudDczNTI3OTM1NQ== jefftriplett 50527 2020-11-28T19:21:09Z 2020-11-28T19:21:09Z CONTRIBUTOR

(Even more annoying is that I see my editor leaked an extra delete space at the end of the line. I'm happy to rebuild this to be less annoying, but you probably don't want the changelog update either way)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fix --metadata doc usage 752749485  
344125441 https://github.com/simonw/datasette/pull/81#issuecomment-344125441 https://api.github.com/repos/simonw/datasette/issues/81 MDEyOklzc3VlQ29tbWVudDM0NDEyNTQ0MQ== jefftriplett 50527 2017-11-14T02:24:54Z 2017-11-14T02:24:54Z CONTRIBUTOR

Oops, if I jumped the gun. I saw the project in my github activity feed and saw some low hanging fruit :) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 :fire: Removes DS_Store 273595473  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);