issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and user = 565628 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • r4vi · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
391355030 https://github.com/simonw/datasette/pull/280#issuecomment-391355030 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTM1NTAzMA== r4vi 565628 2018-05-23T13:53:27Z 2018-05-23T15:22:45Z CONTRIBUTOR

No objections; It's good to go @simonw

On Wed, 23 May 2018, 14:51 Simon Willison, notifications@github.com wrote:

@r4vi https://github.com/r4vi any objections to me merging this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/pull/280#issuecomment-391354237, or mute the thread https://github.com/notifications/unsubscribe-auth/AAihfM_2DN5WR2mkO-VK6ozDmkUQ4IMjks5t1WlcgaJpZM4UI_2m . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391290271 https://github.com/simonw/datasette/pull/280#issuecomment-391290271 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTI5MDI3MQ== r4vi 565628 2018-05-23T09:53:38Z 2018-05-23T09:53:38Z CONTRIBUTOR

Running: bash docker run -p 8001:8001 -v `pwd`:/mnt datasette \ datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \ --load-extension=/usr/local/lib/mod_spatialite.so

is now returning FTS5 enabled in the versions output:

json { "datasette": { "version": "0.22" }, "python": { "full": "3.6.5 (default, May 5 2018, 03:07:21) \n[GCC 6.3.0 20170516]", "version": "3.6.5" }, "sqlite": { "extensions": { "json1": null, "spatialite": "4.4.0-RC0" }, "fts_versions": [ "FTS5", "FTS4", "FTS3" ], "version": "3.23.1" } } The old query didn't work because specifying (t TEXT) caused an error

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391141391 https://github.com/simonw/datasette/pull/280#issuecomment-391141391 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTE0MTM5MQ== r4vi 565628 2018-05-22T21:08:39Z 2018-05-22T21:08:39Z CONTRIBUTOR

I'm going to clean this up for consistency tomorrow morning so hold off merging until then please

On Tue, May 22, 2018 at 6:34 PM, Simon Willison notifications@github.com wrote:

Yeah let's try this without pysqlite3 and see if we still get the correct version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/pull/280#issuecomment-391076458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391059008 https://github.com/simonw/datasette/pull/280#issuecomment-391059008 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTA1OTAwOA== r4vi 565628 2018-05-22T16:40:27Z 2018-05-22T16:40:27Z CONTRIBUTOR

```python

import sqlite3 sqlite3.sqlite_version '3.23.1'

``` running the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);