issue_comments

Table actions

6 rows where author_association = "OWNER", issue = 1087913724 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 6 ✖

issue 1

  • Drop support for Python 3.6 · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1017112130 https://github.com/simonw/datasette/issues/1577#issuecomment-1017112130 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c48n-ZC simonw 9599 2022-01-20T04:33:57Z 2022-01-20T04:33:57Z OWNER

Dropped support for Python 3.6: updated setup.py, changed all references in the documentation to say 3.7 is the minimum required version, got rid of the GitHub Actions tests against 3.6.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  
1017109401 https://github.com/simonw/datasette/issues/1577#issuecomment-1017109401 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c48n9uZ simonw 9599 2022-01-20T04:27:34Z 2022-01-20T04:27:34Z OWNER

OK, now that Uvicorn has dropped 3.6 support - see #1606 - I think this decision is easy to make. I'm dropping 3.6.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  
1000673444 https://github.com/simonw/datasette/issues/1577#issuecomment-1000673444 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c47pRCk simonw 9599 2021-12-24T06:08:58Z 2021-12-24T06:08:58Z OWNER

https://pypistats.org/packages/datasette shows a breakdown of downloads by Python version:

It looks like on a recent day I had 4,071 downloads from Python 3.7... and just 2 downloads from Python 3.6!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  
1000462309 https://github.com/simonw/datasette/issues/1577#issuecomment-1000462309 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c47odfl simonw 9599 2021-12-23T18:20:46Z 2021-12-23T18:20:46Z OWNER

There are a lot of improvements to asyncio in 3.7: https://docs.python.org/3/whatsnew/3.7.html#whatsnew37-asyncio

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  
1000461900 https://github.com/simonw/datasette/issues/1577#issuecomment-1000461900 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c47odZM simonw 9599 2021-12-23T18:19:44Z 2021-12-23T18:19:44Z OWNER

The 3.7 feature I want to use today is contextvars - but I have a workaround for the moment, see https://github.com/simonw/datasette/issues/1576#issuecomment-999987418

So I'm going to hold off on dropping 3.6 for a little bit longer. I imagine I'll drop it before Datasette 1.0 though.

Leaving this issue open to gather thoughts and feedback on this issue from Datasette users and potential users.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  
1000461275 https://github.com/simonw/datasette/issues/1577#issuecomment-1000461275 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c47odPb simonw 9599 2021-12-23T18:18:11Z 2021-12-23T18:18:11Z OWNER

From the Twitter thread, there are still a decent amount of LTS Linux releases out there that are stuck on pre-3.7 Python.

Though many of those are 3.5 and Datasette dropped support for 3.5 in November 2019: cf7776d36fbacefa874cbd6e5fcdc9fff7661203

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Drop support for Python 3.6 1087913724  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);