issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 1094981339 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Better error message if `--convert` code fails to return a dict · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1029475387 https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029475387 https://api.github.com/repos/simonw/sqlite-utils/issues/363 IC_kwDOCGYnMM49XIw7 simonw 9599 2022-02-03T22:52:30Z 2022-02-03T22:52:30Z OWNER

Demos: % sqlite-utils insert /tmp/all.db blah /tmp/log.log --convert '[1]' --text Error: Rows must all be dictionaries, got: 1 % sqlite-utils insert /tmp/all.db blah /tmp/log.log --convert '1' --text Error: --convert must return dict or iterator

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better error message if `--convert` code fails to return a dict 1094981339  
1029469630 https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029469630 https://api.github.com/repos/simonw/sqlite-utils/issues/363 IC_kwDOCGYnMM49XHW- simonw 9599 2022-02-03T22:42:36Z 2022-02-03T22:42:36Z OWNER

This check should run inside the .insert_all() method. It should raise a custom exception which the CLI code can then catch and turn into a click error.

Actually no that doesn't work, because this line causes an error before we even get to .insert_all():

https://github.com/simonw/sqlite-utils/blob/7d928f83085fb285f294dbdaeb93fd94a44d5d44/sqlite_utils/cli.py#L1012-L1013

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better error message if `--convert` code fails to return a dict 1094981339  
1006344080 https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1006344080 https://api.github.com/repos/simonw/sqlite-utils/issues/363 IC_kwDOCGYnMM47-5eQ simonw 9599 2022-01-06T07:32:05Z 2022-01-06T07:32:05Z OWNER

As part of this work I should add test coverage of this error message too: https://github.com/simonw/sqlite-utils/blob/413f8ed754e38d7b190de888c85fe8438336cb11/sqlite_utils/cli.py#L826

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better error message if `--convert` code fails to return a dict 1094981339  
1006343303 https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1006343303 https://api.github.com/repos/simonw/sqlite-utils/issues/363 IC_kwDOCGYnMM47-5SH simonw 9599 2022-01-06T07:30:20Z 2022-01-06T07:30:20Z OWNER

This check should run inside the .insert_all() method. It should raise a custom exception which the CLI code can then catch and turn into a click error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Better error message if `--convert` code fails to return a dict 1094981339  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);