issue_comments

Table actions

5 rows where author_association = "OWNER", issue = 275092453 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 5 ✖

issue 1

  • Redesign JSON output, ditch jsono, offer variants controlled by parameter instead · 5 ✖

author_association 1

  • OWNER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
378279612 https://github.com/simonw/datasette/issues/122#issuecomment-378279612 https://api.github.com/repos/simonw/datasette/issues/122 MDEyOklzc3VlQ29tbWVudDM3ODI3OTYxMg== simonw 9599 2018-04-03T14:55:54Z 2018-04-03T14:55:54Z OWNER

The new documentation for the _shape= parameter is now live at http://datasette.readthedocs.io/en/latest/json_api.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign JSON output, ditch jsono, offer variants controlled by parameter instead 275092453  
345552358 https://github.com/simonw/datasette/issues/122#issuecomment-345552358 https://api.github.com/repos/simonw/datasette/issues/122 MDEyOklzc3VlQ29tbWVudDM0NTU1MjM1OA== simonw 9599 2017-11-19T21:45:38Z 2017-12-05T19:09:52Z OWNER

For the overall shape of the rows:

?_shape=lists (default), ?_shape=objects, ?_shape=object (primary key as object keys)

For getting back extra keys:

?_extras=schema,query,timing

For expanding columns:

?_expand_all=1

Or ?_expand=qSpecies&_expand=qCaretaker

The template view will only be allowed to work with data it can request using extra options.

That leaves one sighted nasty edge-case: the default view will expand all columns, but the .json view of it won't?

I think that's OK. The default view won't include the extras used by the template to render the page either.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign JSON output, ditch jsono, offer variants controlled by parameter instead 275092453  
349408214 https://github.com/simonw/datasette/issues/122#issuecomment-349408214 https://api.github.com/repos/simonw/datasette/issues/122 MDEyOklzc3VlQ29tbWVudDM0OTQwODIxNA== simonw 9599 2017-12-05T19:08:04Z 2017-12-05T19:08:04Z OWNER

I think .json should continue to return rows as list-of-lists - it's a nice default because it produces a smaller overall JSON file. Encouraging people to specify an alternative shape to get the current .jsono format feels appropriate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign JSON output, ditch jsono, offer variants controlled by parameter instead 275092453  
345552500 https://github.com/simonw/datasette/issues/122#issuecomment-345552500 https://api.github.com/repos/simonw/datasette/issues/122 MDEyOklzc3VlQ29tbWVudDM0NTU1MjUwMA== simonw 9599 2017-11-19T21:47:27Z 2017-11-19T21:47:27Z OWNER

To start with, I could just ditch the .jsono in favour of the new _shape argument.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign JSON output, ditch jsono, offer variants controlled by parameter instead 275092453  
345552440 https://github.com/simonw/datasette/issues/122#issuecomment-345552440 https://api.github.com/repos/simonw/datasette/issues/122 MDEyOklzc3VlQ29tbWVudDM0NTU1MjQ0MA== simonw 9599 2017-11-19T21:46:43Z 2017-11-19T21:46:43Z OWNER

This calls for refactoring the code so the table view, the row view and the custom SQL view share as much logic as possible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign JSON output, ditch jsono, offer variants controlled by parameter instead 275092453  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);