issue_comments

Table actions

4 rows where author_association = "OWNER", issue = 607067303 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 4 ✖

issue 1

  • Custom pages mechanism, refs #648 · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
619599904 https://github.com/simonw/datasette/pull/737#issuecomment-619599904 https://api.github.com/repos/simonw/datasette/issues/737 MDEyOklzc3VlQ29tbWVudDYxOTU5OTkwNA== simonw 9599 2020-04-26T18:21:06Z 2020-04-26T18:21:06Z OWNER

Just needs documentation now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages mechanism, refs #648 607067303  
619593899 https://github.com/simonw/datasette/pull/737#issuecomment-619593899 https://api.github.com/repos/simonw/datasette/issues/737 MDEyOklzc3VlQ29tbWVudDYxOTU5Mzg5OQ== simonw 9599 2020-04-26T17:49:06Z 2020-04-26T17:49:06Z OWNER

I'm going with custom_header(name, value), custom_status(numeric_code), custom_redirect("URL").

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages mechanism, refs #648 607067303  
619593811 https://github.com/simonw/datasette/pull/737#issuecomment-619593811 https://api.github.com/repos/simonw/datasette/issues/737 MDEyOklzc3VlQ29tbWVudDYxOTU5MzgxMQ== simonw 9599 2020-04-26T17:48:31Z 2020-04-26T17:48:31Z OWNER

Design challenge: the function that can be called in the custom template to return a custom status code and/or headers.

Proposed design: {{ custom_headers({"x-foo": "bar"}) }} {{ custom_status_code(404) }} Or should I combine them into one function? {{ custom_headers({"x-foo": "bar"}, status=404) }} A common use-case here would be a redirect. How should that look? {{ custom_redirect("/foo") }} - defaults to 301 {{ custom_redirect("/foo", status=302) }} Maybe avoid dictionary syntax entirely: {{ custom_header("x-foo", "bar") }}

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages mechanism, refs #648 607067303  
619591533 https://github.com/simonw/datasette/pull/737#issuecomment-619591533 https://api.github.com/repos/simonw/datasette/issues/737 MDEyOklzc3VlQ29tbWVudDYxOTU5MTUzMw== simonw 9599 2020-04-26T17:33:48Z 2020-04-26T17:33:48Z OWNER

Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow.

I think I could do that with a custom template function - if that function is called during the render then we follow those instructions instead of returning the rendered HTML. https://github.com/simonw/datasette/issues/648#issuecomment-619591380

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages mechanism, refs #648 607067303  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);