issue_comments

Table actions

10 rows where author_association = "OWNER", issue = 639072811 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 10 ✖

issue 1

  • Rename master branch to main · 10 ✖

author_association 1

  • OWNER · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
649908756 https://github.com/simonw/datasette/issues/849#issuecomment-649908756 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0OTkwODc1Ng== simonw 9599 2020-06-26T02:09:09Z 2022-10-27T13:57:08Z OWNER

I mentioned this issue here: https://simonwillison.net/2020/Jun/26/weeknotes-plugins-sqlite-generate/

Repositories created by following the README in https://github.com/simonw/datasette-template and https://github.com/simonw/click-app have a main branch instead of master so I have a few examples live now. https://github.com/simonw/datasette-saved-queries is one example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
692965391 https://github.com/simonw/datasette/issues/849#issuecomment-692965391 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY5Mjk2NTM5MQ== simonw 9599 2020-09-15T20:37:14Z 2020-09-15T20:37:14Z OWNER

I've been running on main for a while now with no issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
667424128 https://github.com/simonw/datasette/issues/849#issuecomment-667424128 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY2NzQyNDEyOA== simonw 9599 2020-07-31T23:21:56Z 2020-07-31T23:23:24Z OWNER

I'm going to change the default branch on the GitHub repository. If something breaks I can always change it back again.

Done that! Default is now main.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
667424020 https://github.com/simonw/datasette/issues/849#issuecomment-667424020 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY2NzQyNDAyMA== simonw 9599 2020-07-31T23:21:30Z 2020-07-31T23:21:30Z OWNER

https://github.com/simonw/datasette/tree/main branch now exists and will automatically mirror master (and vice-versa).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
667295759 https://github.com/simonw/datasette/issues/849#issuecomment-667295759 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY2NzI5NTc1OQ== simonw 9599 2020-07-31T18:45:35Z 2020-07-31T18:45:35Z OWNER

Watch out for places in the documentation that might link to master - e.g. here:

https://github.com/simonw/datasette/blob/2d7fa8b9058dfbf9c7c371cdeec115d32a177dc9/docs/custom_templates.rst#L247

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
646686493 https://github.com/simonw/datasette/issues/849#issuecomment-646686493 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0NjY4NjQ5Mw== simonw 9599 2020-06-19T15:04:51Z 2020-06-19T15:04:51Z OWNER

https://twitter.com/jaffathecake/status/1273983493006077952 concerns what happens to open pull requests - they will automatically close when you remove master unless you repoint them to main first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
644584075 https://github.com/simonw/datasette/issues/849#issuecomment-644584075 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0NDU4NDA3NQ== simonw 9599 2020-06-16T07:24:08Z 2020-06-16T07:24:08Z OWNER

This guide is fantastic - I'll be following it closely: https://github.com/chancancode/branch-rename/blob/main/README.md - in particular the Action to mirror master and main for a while.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
644384787 https://github.com/simonw/datasette/issues/849#issuecomment-644384787 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0NDM4NDc4Nw== simonw 9599 2020-06-15T20:56:07Z 2020-06-15T20:56:19Z OWNER

The big question is how this impacts existing CI configuration. datasette-psutil is configured to use Circle CI, what happens if I push a new commit?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
644384417 https://github.com/simonw/datasette/issues/849#issuecomment-644384417 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0NDM4NDQxNw== simonw 9599 2020-06-15T20:55:23Z 2020-06-15T20:55:23Z OWNER

I'm doing https://github.com/simonw/datasette-psutil first.

In my local checkout: git branch -m master main git push -u origin main (Thanks, https://www.hanselman.com/blog/EasilyRenameYourGitDefaultBranchFromMasterToMain.aspx)

Then in https://github.com/simonw/datasette-psutil/settings/branches I changed the default branch to main.

Links to these docs: https://help.github.com/en/github/administering-a-repository/setting-the-default-branch

That worked! https://github.com/simonw/datasette-psutil

One catch, which I think will impact my most widely used repos the most (like datasette) - linking to a specific file now looks like this:

https://github.com/simonw/datasette-psutil/blob/main/datasette_psutil/init.py

The old https://github.com/simonw/datasette-psutil/blob/master/datasette_psutil/init.py link is presumably frozen in time?

I've definitely got links spread around the web to my "most recent version of this code" that would use the master reference, which would need to be updated to main instead. Most of those are probably in the Datasette docs and on my blog though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  
644322234 https://github.com/simonw/datasette/issues/849#issuecomment-644322234 https://api.github.com/repos/simonw/datasette/issues/849 MDEyOklzc3VlQ29tbWVudDY0NDMyMjIzNA== simonw 9599 2020-06-15T19:06:16Z 2020-06-15T19:06:16Z OWNER

I'll make this change on a few of my other repos first to make sure I haven't missed any tricky edge-cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename master branch to main 639072811  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);