issue_comments

Table actions

4 rows where issue = 1065432388 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Maybe return JSON from HTML pages if `Accept: application/json` is sent · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1028461220 https://github.com/simonw/datasette/issues/1534#issuecomment-1028461220 https://api.github.com/repos/simonw/datasette/issues/1534 IC_kwDOBm6k_c49TRKk simonw 9599 2022-02-02T23:39:33Z 2022-02-02T23:39:33Z OWNER

I've decided not to do this, because of the risk that Cloudflare could cache the JSON version for an HTML page or vice-versa.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Maybe return JSON from HTML pages if `Accept: application/json` is sent 1065432388  
1005975080 https://github.com/simonw/datasette/issues/1534#issuecomment-1005975080 https://api.github.com/repos/simonw/datasette/issues/1534 IC_kwDOBm6k_c479fYo simonw 9599 2022-01-05T18:29:06Z 2022-01-05T18:29:06Z OWNER

A really big downside to this is that it turns out many CDNs - apparently including Cloudflare - don't support the Vary header at all!

More in this thread: https://twitter.com/simonw/status/1478470282931163137

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Maybe return JSON from HTML pages if `Accept: application/json` is sent 1065432388  
1000535904 https://github.com/simonw/datasette/issues/1534#issuecomment-1000535904 https://api.github.com/repos/simonw/datasette/issues/1534 IC_kwDOBm6k_c47ovdg simonw 9599 2021-12-23T21:44:31Z 2021-12-23T21:44:31Z OWNER

A big downside to this is that I would need to use Vary: Accept for when Datasette is running behind a cache such as Cloudflare - would that greatly reduce overall cache efficiency due to subtle variations in the accept headers sent by common browsers?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Maybe return JSON from HTML pages if `Accept: application/json` is sent 1065432388  
981149531 https://github.com/simonw/datasette/issues/1534#issuecomment-981149531 https://api.github.com/repos/simonw/datasette/issues/1534 IC_kwDOBm6k_c46eydb simonw 9599 2021-11-28T20:48:54Z 2021-11-28T20:48:54Z OWNER

If I'm going to do this, is there value in also spotting Accept: text/csv and returning CSV for that? I'm pretty sure no client has EVER implemented this though, so it feels like it would be showboating.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Maybe return JSON from HTML pages if `Accept: application/json` is sent 1065432388  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);