issue_comments

Table actions

4 rows where issue = 1077322009 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Allow users to pass a full convert() function definition · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
991395494 https://github.com/simonw/sqlite-utils/issues/355#issuecomment-991395494 https://api.github.com/repos/simonw/sqlite-utils/issues/355 IC_kwDOCGYnMM47F36m simonw 9599 2021-12-11T00:50:22Z 2021-12-11T00:51:15Z OWNER

Here's an example of the new (slightly confusing) error message: ```bash sqlite-utils convert fixtures.db roadside_attractions name ' def foo(value)
bar baz ' Error: Syntax error in code:

def foo(value)

invalid syntax Another: sqlite-utils convert fixtures.db roadside_attractions name '$' Error: Syntax error in code:

return $

invalid syntax ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow users to pass a full convert() function definition 1077322009  
991393684 https://github.com/simonw/sqlite-utils/issues/355#issuecomment-991393684 https://api.github.com/repos/simonw/sqlite-utils/issues/355 IC_kwDOCGYnMM47F3eU simonw 9599 2021-12-11T00:42:19Z 2021-12-11T00:49:49Z OWNER

Ideally I'd like to show the perfect syntax error messages to the user - but I don't know if it's possible to do this cleanly because the error might occur with their originally entered code OR it might occur after I add def fn(value) to it.

I'm going to punt on that for the moment and tolerate slightly confusing syntax errors.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow users to pass a full convert() function definition 1077322009  
991386841 https://github.com/simonw/sqlite-utils/issues/355#issuecomment-991386841 https://api.github.com/repos/simonw/sqlite-utils/issues/355 IC_kwDOCGYnMM47F1zZ simonw 9599 2021-12-11T00:14:11Z 2021-12-11T00:15:15Z OWNER

Relevant code: https://github.com/simonw/sqlite-utils/blob/7a43af232e4bc00bd227307665163614e225948b/sqlite_utils/cli.py#L2128-L2135

One way to implement this would be to look to see if the code starts with def ... - but that's not going to work for proper module that start with a docstring or imports.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow users to pass a full convert() function definition 1077322009  
991387044 https://github.com/simonw/sqlite-utils/issues/355#issuecomment-991387044 https://api.github.com/repos/simonw/sqlite-utils/issues/355 IC_kwDOCGYnMM47F12k simonw 9599 2021-12-11T00:14:45Z 2021-12-11T00:14:45Z OWNER

Maybe attempt to compile their code, and if it fails try again after adding def fn(value): to the start?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow users to pass a full convert() function definition 1077322009  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);