issue_comments

Table actions

3 rows where issue = 1082584499 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Redesign `facet_results` JSON structure prior to Datasette 1.0 · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1375800361 https://github.com/simonw/datasette/issues/1558#issuecomment-1375800361 https://api.github.com/repos/simonw/datasette/issues/1558 IC_kwDOBm6k_c5SAQwp simonw 9599 2023-01-09T15:31:17Z 2023-01-09T15:31:17Z OWNER

Related: - #782 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign `facet_results` JSON structure prior to Datasette 1.0 1082584499  
996204369 https://github.com/simonw/datasette/issues/1558#issuecomment-996204369 https://api.github.com/repos/simonw/datasette/issues/1558 IC_kwDOBm6k_c47YN9R simonw 9599 2021-12-16T21:23:25Z 2021-12-16T21:23:25Z OWNER

Related: Following the fix for #625 I noticed that facets_timed_out gives you just the column name, but doesn't let you know which particular type of facet (date or array for example) suffered the timeout: https://github.com/simonw/datasette/blob/0d4145d0f4d8b2a7edc1ba4aac1be56cd536a10a/datasette/facets.py#L269-L270

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign `facet_results` JSON structure prior to Datasette 1.0 1082584499  
996134716 https://github.com/simonw/datasette/issues/1558#issuecomment-996134716 https://api.github.com/repos/simonw/datasette/issues/1558 IC_kwDOBm6k_c47X888 simonw 9599 2021-12-16T19:46:21Z 2021-12-16T19:46:21Z OWNER

The flaw in the current design is illustrated by this example:

"facet_results": { "tags": { "name": "tags", "type": "array", "results": [...], "hideable": false, "toggle_url": "/fixtures/facetable.json?_facet=tags&_trace=1&_nosuggest=1", "truncated": false }, "created": { "name": "created", "type": "date", "results": [...] This was the cause of the bug in #625 - the each of those objects is keyed by the name of the column, which left no room for faceting the same column once by date and once by column value.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Redesign `facet_results` JSON structure prior to Datasette 1.0 1082584499  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);