issue_comments

Table actions

6 rows where issue = 1082743068 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • filters_from_request plugin hook, now used in TableView · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
997082676 https://github.com/simonw/datasette/pull/1559#issuecomment-997082676 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47bkY0 simonw 9599 2021-12-17T23:09:41Z 2021-12-17T23:09:41Z OWNER

This is now available to try out in Datasette 0.60a0: https://github.com/simonw/datasette/releases/tag/0.60a0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  
996961196 https://github.com/simonw/datasette/pull/1559#issuecomment-996961196 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47bGus simonw 9599 2021-12-17T19:00:53Z 2021-12-17T19:00:53Z OWNER

I'm going to merge this to main now. I can continue the refactoring there, but having it in main means I can put out an alpha release with the new hook which will unblock me from running tests against it in this repo: https://github.com/simonw/datasette-leaflet-freedraw/pull/8

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  
996959325 https://github.com/simonw/datasette/pull/1559#issuecomment-996959325 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47bGRd simonw 9599 2021-12-17T18:59:54Z 2021-12-17T18:59:54Z OWNER

I've convinced myself that this plugin hook design is good through this datasette-leaflet-freedraw prototype: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/init.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  
996289541 https://github.com/simonw/datasette/pull/1559#issuecomment-996289541 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47YiwF codecov[bot] 22429695 2021-12-17T00:07:42Z 2021-12-17T17:28:54Z NONE

Codecov Report

Merging #1559 (71af58d) into main (0663d55) will increase coverage by 0.09%. The diff coverage is 97.97%.

```diff @@ Coverage Diff @@

main #1559 +/-

========================================== + Coverage 91.96% 92.05% +0.09%
========================================== Files 34 34
Lines 4442 4493 +51
========================================== + Hits 4085 4136 +51
Misses 357 357
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/plugins.py | 82.35% <ø> (ø) | | | datasette/filters.py | 95.69% <97.67%> (+1.33%) | :arrow_up: | | datasette/hookspecs.py | 100.00% <100.00%> (ø) | | | datasette/views/table.py | 96.21% <100.00%> (+0.13%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0663d55...71af58d. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  
996895423 https://github.com/simonw/datasette/pull/1559#issuecomment-996895423 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47a2q_ simonw 9599 2021-12-17T17:28:44Z 2021-12-17T17:28:44Z OWNER

Before I land this I'm going to build one prototype plugin against it to confirm that the new hook is useful in its current shape.

I'll add support for filtering a table by drawing on a map to https://datasette.io/plugins/datasette-leaflet-freedraw

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  
996286808 https://github.com/simonw/datasette/pull/1559#issuecomment-996286808 https://api.github.com/repos/simonw/datasette/issues/1559 IC_kwDOBm6k_c47YiFY simonw 9599 2021-12-17T00:01:43Z 2021-12-17T00:01:43Z OWNER

This already has tests and documentation, and I've used it to refactor out the logic for ?_where= and ?_search= and ?_through=.

Do I like this enough to land it on main?

Also, I think I can still use it to refactor out the Filters code that implements ?col=x and ?col__lt=5 and suchlike.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 filters_from_request plugin hook, now used in TableView 1082743068  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);