issue_comments

Table actions

4 rows where issue = 1083246400 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1 · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
997082189 https://github.com/simonw/datasette/pull/1562#issuecomment-997082189 https://api.github.com/repos/simonw/datasette/issues/1562 IC_kwDOBm6k_c47bkRN simonw 9599 2021-12-17T23:08:14Z 2021-12-17T23:08:14Z OWNER

Oh that makes sense: In Python 3.6 this happens: Collecting janus<1.1,>=0.6.2 Using cached janus-0.7.0-py3-none-any.whl (6.9 kB) While in Python 3.7 or higher this happens: Collecting janus<1.1,>=0.6.2 Downloading janus-1.0.0-py3-none-any.whl (6.9 kB) So this is safe to apply because pip is smart enough to pick the version of Janus that works for that Python version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1 1083246400  
997081673 https://github.com/simonw/datasette/pull/1562#issuecomment-997081673 https://api.github.com/repos/simonw/datasette/issues/1562 IC_kwDOBm6k_c47bkJJ simonw 9599 2021-12-17T23:06:38Z 2021-12-17T23:06:38Z OWNER

From this diff between 0.7.0 and 1.0: https://github.com/aio-libs/janus/compare/v0.7.0...v1.0.0

It looks like the only change relevant to compatibility is loop = asyncio.get_running_loop() directly instead of falling back to asyncio.get_event_loop() if get_running_loop isn't available.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1 1083246400  
997080352 https://github.com/simonw/datasette/pull/1562#issuecomment-997080352 https://api.github.com/repos/simonw/datasette/issues/1562 IC_kwDOBm6k_c47bj0g simonw 9599 2021-12-17T23:03:08Z 2021-12-17T23:03:08Z OWNER

They say they've dropped 3.6 support, but Datasette's tests against 3.6 are still passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1 1083246400  
996716158 https://github.com/simonw/datasette/pull/1562#issuecomment-996716158 https://api.github.com/repos/simonw/datasette/issues/1562 IC_kwDOBm6k_c47aK5- codecov[bot] 22429695 2021-12-17T13:18:49Z 2021-12-17T13:18:49Z NONE

Codecov Report

Merging #1562 (2f008e8) into main (0663d55) will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1562 +/-

======================================= Coverage 91.96% 91.96%
======================================= Files 34 34
Lines 4442 4442
======================================= Hits 4085 4085
Misses 357 357
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0663d55...2f008e8. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1 1083246400  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);