home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 1121583414 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

  • simonw 2
  • BryantD 1
  • noslouch 1
  • henrikek 1

author_association 2

  • NONE 3
  • OWNER 2

issue 1

  • JSON link on row page is 404 if base_url setting is used · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1483009959 https://github.com/simonw/datasette/issues/1619#issuecomment-1483009959 https://api.github.com/repos/simonw/datasette/issues/1619 IC_kwDOBm6k_c5YZO-n henrikek 6613091 2023-03-24T15:38:04Z 2023-03-24T15:38:04Z NONE

I also have the same problem when running behind an apache proxy server with base_url. However, I have researched the problem a bit and have come to the conclusion that if you change _facet_date to _facet in the following https://github.com/simonw/datasette/blob/3feed1f66e2b746f349ee56970a62246a18bb164/datasette/facets.py#LL493C57-L493C68 , the facets work. But I'm not sure if this has other consequences?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
JSON link on row page is 404 if base_url setting is used 1121583414  
1455196849 https://github.com/simonw/datasette/issues/1619#issuecomment-1455196849 https://api.github.com/repos/simonw/datasette/issues/1619 IC_kwDOBm6k_c5WvIqx BryantD 969875 2023-03-05T20:29:55Z 2023-03-05T20:30:14Z NONE

I have this same issue, which is happening with both json links and facets. It is not happening with column sort links in the gear popup menus, but it is happening with the sort arrow that results after you use one of those links. I'm using Apache as a proxy to Datasette; the relevant configs are:

ProxyPass /datasette/ http://127.0.0.1:8000/datasette/ nocanon ProxyPreserveHost on

{ "base_url": "/datasette/" }

If it would be useful to get a look at the running installation via the Web, Simon, let me know.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
JSON link on row page is 404 if base_url setting is used 1121583414  
1353721442 https://github.com/simonw/datasette/issues/1619#issuecomment-1353721442 https://api.github.com/repos/simonw/datasette/issues/1619 IC_kwDOBm6k_c5QsCZi noslouch 2090382 2022-12-15T21:20:53Z 2022-12-15T21:20:53Z NONE

i'm also getting bit by this. I'm trying to set up an nginx reverse proxy in front of multiple datasette backends.

When I run it locally or behind the proxy, I see the base_url value added a second time to the path for various action links on table pages (view as JSON, sort by column, etc).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
JSON link on row page is 404 if base_url setting is used 1121583414  
1027647257 https://github.com/simonw/datasette/issues/1619#issuecomment-1027647257 https://api.github.com/repos/simonw/datasette/issues/1619 IC_kwDOBm6k_c49QKcZ simonw 9599 2022-02-02T07:11:43Z 2022-02-02T07:11:43Z OWNER

Weirdly the bug does NOT exhibit itself on this demo: https://datasette-apache-proxy-demo.datasette.io/prefix/fixtures/no_primary_key/1 - which correctly links to https://datasette-apache-proxy-demo.datasette.io/prefix/fixtures/no_primary_key/1.json

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
JSON link on row page is 404 if base_url setting is used 1121583414  
1027646659 https://github.com/simonw/datasette/issues/1619#issuecomment-1027646659 https://api.github.com/repos/simonw/datasette/issues/1619 IC_kwDOBm6k_c49QKTD simonw 9599 2022-02-02T07:10:37Z 2022-02-02T07:10:37Z OWNER

It's not just the table with slashes in the name. Same thing on http://127.0.0.1:3344/foo/bar/fixtures/attraction_characteristic/1 - the json link goes to a JSON-rendered 404 on http://127.0.0.1:3344/foo/bar/foo/bar/fixtures/attraction_characteristic/1.json

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
JSON link on row page is 404 if base_url setting is used 1121583414  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 19.354ms · About: github-to-sqlite