issue_comments

Table actions

6 rows where issue = 1126604194 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • datasette one.db one.db opens database twice, as one and one_2 · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1032057472 https://github.com/simonw/datasette/issues/1632#issuecomment-1032057472 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g_KA simonw 9599 2022-02-07T23:50:01Z 2022-02-07T23:50:01Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  
1032050489 https://github.com/simonw/datasette/issues/1632#issuecomment-1032050489 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g9c5 simonw 9599 2022-02-07T23:39:11Z 2022-02-07T23:42:08Z OWNER

That implementation broke on Python 3.6 - which is still a supported Python version for the 0.60.x branch - test_homepage failed.

```

  assert (
        "2 rows in 1 table, 5 rows in 4 hidden tables, 1 view" == counts_p.text.strip()
    )

E AssertionError: assert '2 rows in 1 ...ables, 1 view' == '1 table, 4 h...ables, 1 view' E - 1 table, 4 hidden tables, 1 view E + 2 rows in 1 table, 5 rows in 4 hidden tables, 1 view E ? ++++++++++ ++++++++++ ``` That's because this idiom isn't guaranteed to preserve order in versions earlier than Python 3.7:

https://github.com/simonw/datasette/blob/fa5fc327adbbf70656ac533912f3fc0526a3873d/datasette/cli.py#L552-L553

I could say that 0.60.2 is the first version to require Python 3.7 - but that feels a little surprising.

I'm going to use a different idiom for order-preserving de-duplication from this StackOverflow instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  
1032037391 https://github.com/simonw/datasette/issues/1632#issuecomment-1032037391 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g6QP simonw 9599 2022-02-07T23:21:07Z 2022-02-07T23:21:07Z OWNER

For the record, here's the code that picks the one_2 name if that stem is already used as a database name: https://github.com/simonw/datasette/blob/03305ea183b1534bc4cef3a721fe5f3700273b84/datasette/app.py#L401-L417

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  
1032036525 https://github.com/simonw/datasette/issues/1632#issuecomment-1032036525 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g6Ct simonw 9599 2022-02-07T23:19:59Z 2022-02-07T23:19:59Z OWNER

I'm going to fix this in the CLI code itself, rather than fixing it in the Datasette constructor. That way if someone has a truly weird reason to want this behaviour they can construct Datasette directly.

https://github.com/simonw/datasette/blob/03305ea183b1534bc4cef3a721fe5f3700273b84/datasette/cli.py#L535-L550

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  
1032034015 https://github.com/simonw/datasette/issues/1632#issuecomment-1032034015 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g5bf simonw 9599 2022-02-07T23:17:57Z 2022-02-07T23:17:57Z OWNER

I'm going to fix this in a 0.60.2 bug fix release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  
1032032686 https://github.com/simonw/datasette/issues/1632#issuecomment-1032032686 https://api.github.com/repos/simonw/datasette/issues/1632 IC_kwDOBm6k_c49g5Gu simonw 9599 2022-02-07T23:16:10Z 2022-02-07T23:16:10Z OWNER

I found this bug while trying to get the following to work:

datasette /data/one.db /data/two.db /data/*.db --create

I want this to create any missing database files on startup out of that literal list of one.db and two.db and to also open any other *.db files in that folder - needed for datasette-publish-fly in https://github.com/simonw/datasette-publish-fly/pull/12#issuecomment-1032029874

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette one.db one.db opens database twice, as one and one_2 1126604194  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);