home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 1214859703 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 3

issue 1

  • Refactor `RowView` and remove `RowTableShared` · 3 ✖

author_association 1

  • OWNER 3
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1108907238 https://github.com/simonw/datasette/issues/1719#issuecomment-1108907238 https://api.github.com/repos/simonw/datasette/issues/1719 IC_kwDOBm6k_c5CGJTm simonw 9599 2022-04-25T18:34:21Z 2022-04-25T18:34:21Z OWNER

Well this refactor turned out to be pretty quick and really does greatly simplify both the RowView and TableView classes. Very happy with this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor `RowView` and remove `RowTableShared` 1214859703  
1108888494 https://github.com/simonw/datasette/issues/1719#issuecomment-1108888494 https://api.github.com/repos/simonw/datasette/issues/1719 IC_kwDOBm6k_c5CGEuu simonw 9599 2022-04-25T18:15:42Z 2022-04-25T18:15:42Z OWNER

Here's an undocumented feature I forgot existed: https://latest.datasette.io/fixtures/simple_primary_key/1.json?_extras=foreign_key_tables

?_extras=foreign_key_tables

https://github.com/simonw/datasette/blob/0bc5186b7bb4fc82392df08f99a9132f84dcb331/datasette/views/table.py#L1021-L1024

It's even covered by the tests:

https://github.com/simonw/datasette/blob/b9c2b1cfc8692b9700416db98721fa3ec982f6be/tests/test_api.py#L691-L703

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor `RowView` and remove `RowTableShared` 1214859703  
1108884171 https://github.com/simonw/datasette/issues/1719#issuecomment-1108884171 https://api.github.com/repos/simonw/datasette/issues/1719 IC_kwDOBm6k_c5CGDrL simonw 9599 2022-04-25T18:10:46Z 2022-04-25T18:12:45Z OWNER

It looks like the only class method from that shared class needed by RowView is self.display_columns_and_rows().

Which I've been wanting to refactor to provide to QueryView too:

  • 715

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor `RowView` and remove `RowTableShared` 1214859703  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 19.614ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows