issue_comments

Table actions

4 rows where issue = 1223459734 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Automated test for Pyodide compatibility · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1115470180 https://github.com/simonw/datasette/issues/1737#issuecomment-1115470180 https://api.github.com/repos/simonw/datasette/issues/1737 IC_kwDOBm6k_c5CfLlk simonw 9599 2022-05-02T23:39:29Z 2022-05-02T23:39:29Z OWNER

Test ran in 38 seconds and passed! https://github.com/simonw/datasette/runs/6265954274?check_suite_focus=true

I'm going to have it run on every commit and PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Automated test for Pyodide compatibility 1223459734  
1115468193 https://github.com/simonw/datasette/issues/1737#issuecomment-1115468193 https://api.github.com/repos/simonw/datasette/issues/1737 IC_kwDOBm6k_c5CfLGh simonw 9599 2022-05-02T23:35:26Z 2022-05-02T23:35:26Z OWNER

https://github.com/simonw/datasette/runs/6265915080?check_suite_focus=true failed but looks like it passed because I forgot to use set -e at the start of the bash script.

It failed because it didn't have build available.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Automated test for Pyodide compatibility 1223459734  
1115464097 https://github.com/simonw/datasette/issues/1737#issuecomment-1115464097 https://api.github.com/repos/simonw/datasette/issues/1737 IC_kwDOBm6k_c5CfKGh simonw 9599 2022-05-02T23:27:40Z 2022-05-02T23:27:40Z OWNER

I'm going to start off by running this manually - I may run it on every commit once this is all a little bit more stable.

I can base the workflow on https://github.com/simonw/scrape-hacker-news-by-domain/blob/main/.github/workflows/scrape.yml

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Automated test for Pyodide compatibility 1223459734  
1115462720 https://github.com/simonw/datasette/issues/1737#issuecomment-1115462720 https://api.github.com/repos/simonw/datasette/issues/1737 IC_kwDOBm6k_c5CfJxA simonw 9599 2022-05-02T23:25:03Z 2022-05-02T23:25:03Z OWNER

Here's a script that seems to work. It builds the wheel, starts a Python web server that serves the wheel, runs a test with shot-scraper and then shuts down the server again.

```bash

!/bin/bash

Build the wheel

python3 -m build

Find name of wheel

wheel=$(basename $(ls dist/*.whl))

strip off the dist/

Create a blank index page

echo '

<script src="https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js"></script>

' > dist/index.html

Run a server for that dist/ folder

cd dist python3 -m http.server 8529 & cd ..

shot-scraper javascript http://localhost:8529/ " async () => { let pyodide = await loadPyodide(); await pyodide.loadPackage(['micropip', 'ssl', 'setuptools']); let output = await pyodide.runPythonAsync(` import micropip await micropip.install('h11==0.12.0') await micropip.install('http://localhost:8529/$wheel') import ssl import setuptools from datasette.app import Datasette ds = Datasette(memory=True, settings={'num_sql_threads': 0}) (await ds.client.get('/_memory.json?sql=select+55+as+itworks&_shape=array')).text `); if (JSON.parse(output)[0].itworks != 55) { throw 'Got ' + output + ', expected itworks: 55'; } return 'Test passed!'; } "

Shut down the server

pkill -f 'http.server 8529' ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Automated test for Pyodide compatibility 1223459734  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);