issue_comments

Table actions

9 rows where issue = 1344823170 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Add new entrypoint option to `--load-extension` · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1224592097 https://github.com/simonw/datasette/pull/1789#issuecomment-1224592097 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5I_crh simonw 9599 2022-08-23T18:42:51Z 2022-08-23T18:42:51Z OWNER

Looks like it's not actually necessary to apt-get install anything extra in order to compile that test extension:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1224569313 https://github.com/simonw/datasette/pull/1789#issuecomment-1224569313 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5I_XHh simonw 9599 2022-08-23T18:33:08Z 2022-08-23T18:33:08Z OWNER

I'm going to merge as-is and then figure out the GitHub Actions bit separately. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1223347322 https://github.com/simonw/datasette/pull/1789#issuecomment-1223347322 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5I6sx6 asg017 15178711 2022-08-23T00:03:20Z 2022-08-23T00:03:20Z CONTRIBUTOR

@simonw to build the extension on ubuntu, you can run:

apt-get update && apt-get install libsqlite3-dev gcc gcc ext.c -fPIC -shared -o ext.so

I'm not the best with Actions, but if you set the cache key to ext.c, run those two commands to download dependencies + compile to ext.so, then the unit test should pick it up and run it correctly. Let me know if you want me to update the PR with that added

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221621084 https://github.com/simonw/datasette/pull/1789#issuecomment-1221621084 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5I0HVc simonw 9599 2022-08-21T21:07:25Z 2022-08-21T21:07:25Z OWNER

Any tips on how I can get the GitHub Action test.yml workflow to compile this so that the test runs there?

I imagine I need an extra step before https://github.com/simonw/datasette/blob/663ac431fe7202c85967568d82b2034f92b9aa43/.github/workflows/test.yml#L31

Neatest thing would be to cache the compiled file between actions runs (in the Actions cache) so we don't have to add the SQLite build dependencies on most runs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221576460 https://github.com/simonw/datasette/pull/1789#issuecomment-1221576460 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5Iz8cM asg017 15178711 2022-08-21T16:16:42Z 2022-08-21T16:16:42Z CONTRIBUTOR

Rebased, Read the docs failure should now now fixed

Re docs - ya that's a pretty ambitious page, I'm still not 100% sure what the best practices are/should be... Would be happy to make that page in a future PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221181076 https://github.com/simonw/datasette/pull/1789#issuecomment-1221181076 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5Iyb6U simonw 9599 2022-08-20T00:07:25Z 2022-08-20T00:07:25Z OWNER

I don't think we should block landing this PR on that though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221180941 https://github.com/simonw/datasette/pull/1789#issuecomment-1221180941 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5Iyb4N simonw 9599 2022-08-20T00:07:00Z 2022-08-20T00:07:00Z OWNER

If you wanted to be really ambitious about documentation a page that explained what it takes to actually run SQLite extensions in Python would be great. I'm still trying to figure out the best way to do that in macOS myself.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221180327 https://github.com/simonw/datasette/pull/1789#issuecomment-1221180327 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5Iybun simonw 9599 2022-08-20T00:05:03Z 2022-08-20T00:05:03Z OWNER

If you cherry-pick in the fix from #1778 it should fix the Read the Docs failure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  
1221179830 https://github.com/simonw/datasette/pull/1789#issuecomment-1221179830 https://api.github.com/repos/simonw/datasette/issues/1789 IC_kwDOBm6k_c5Iybm2 simonw 9599 2022-08-20T00:03:23Z 2022-08-20T00:03:23Z OWNER

This looks great!

You need to run cog -r docs/*.rst to update the docs, then add those to the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new entrypoint option to `--load-extension` 1344823170  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);