issue_comments

Table actions

6 rows where issue = 1348294436 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • db[table].create(..., transform=True) and create-table --transform · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1229303691 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1229303691 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5JRa-L simonw 9599 2022-08-27T23:13:06Z 2022-08-27T23:13:06Z OWNER

Documentation: - https://sqlite-utils--468.org.readthedocs.build/en/468/python-api.html#explicitly-creating-a-table - https://sqlite-utils--468.org.readthedocs.build/en/468/cli.html#creating-tables

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  
1224412060 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1224412060 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5I-wuc codecov[bot] 22429695 2022-08-23T17:30:24Z 2022-08-27T23:11:44Z NONE

Codecov Report

Merging #468 (fc38480) into main (c5f8a2e) will decrease coverage by 0.12%. The diff coverage is 88.88%.

:exclamation: Current head fc38480 differs from pull request most recent head 2f6a64f. Consider uploading reports for the commit 2f6a64f to get more accurate results

```diff @@ Coverage Diff @@

main #468 +/-

========================================== - Coverage 96.60% 96.47% -0.13%
========================================== Files 6 6
Lines 2590 2640 +50
========================================== + Hits 2502 2547 +45
- Misses 88 93 +5
```

| Impacted Files | Coverage Δ | | |---|---|---| | sqlite_utils/cli.py | 95.86% <66.66%> (-0.09%) | :arrow_down: | | sqlite_utils/db.py | 97.31% <90.19%> (-0.23%) | :arrow_down: |

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  
1229284539 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1229284539 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5JRWS7 simonw 9599 2022-08-27T22:54:07Z 2022-08-27T22:55:01Z OWNER

Just needs documentation now, which can go here: https://sqlite-utils--468.org.readthedocs.build/en/468/python-api.html#explicitly-creating-a-table

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  
1229279539 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1229279539 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5JRVEz simonw 9599 2022-08-27T22:24:33Z 2022-08-27T22:24:33Z OWNER

Interesting challenge with default_value: I need to be able to tell if the default values passed to .create() differ from those in the database already.

Introspecting that is a bit tricky:

```pycon

import sqlite_utils db = sqlite_utils.Database(memory=True) db["blah"].create({"id": int, "name": str}, not_null=("name",), defaults={"name": "bob"})

<Table blah (id, name)> >>> db["blah"].columns [Column(cid=0, name='id', type='INTEGER', notnull=0, default_value=None, is_pk=0), Column(cid=1, name='name', type='TEXT', notnull=1, default_value="'bob'", is_pk=0)] ``` Note how a default value of the Python string `bob` is represented in the results of `PRAGMA table_info()` as `default_value="'bob'"` - it's got single quotes added to it! So comparing default values from introspecting the database needs me to first parse that syntax. This may require a new table introspection method.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  
1229276554 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1229276554 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5JRUWK simonw 9599 2022-08-27T22:05:40Z 2022-08-27T22:05:51Z OWNER

For the moment I'm not going to pay attention to foreign_keys changes - I will note that these are not modified in the documentation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  
1229207725 https://github.com/simonw/sqlite-utils/pull/468#issuecomment-1229207725 https://api.github.com/repos/simonw/sqlite-utils/issues/468 IC_kwDOCGYnMM5JRDit simonw 9599 2022-08-27T14:55:32Z 2022-08-27T22:03:50Z OWNER

The main challenge here is coming up with comprehensive tests. The cases I need to cover are from this block of code:

https://github.com/simonw/sqlite-utils/blob/c5f8a2eb1a81a18b52825cc649112f71fe419b12/sqlite_utils/db.py#L1468-L1480

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 db[table].create(..., transform=True) and create-table --transform 1348294436  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);