issue_comments

Table actions

5 rows where issue = 1432037325 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Make it easier to fix URL proxy problems · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1299098458 https://github.com/simonw/datasette/issues/1879#issuecomment-1299098458 https://api.github.com/repos/simonw/datasette/issues/1879 IC_kwDOBm6k_c5Nbqta simonw 9599 2022-11-01T20:27:40Z 2022-11-01T20:33:52Z OWNER

https://github.com/simonw/datasette-x-forwarded-host/blob/main/datasette_x_forwarded_host/init.py could happen in core controlled by:

--setting trust_forwarded_host 1

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it easier to fix URL proxy problems 1432037325  
1299102108 https://github.com/simonw/datasette/issues/1879#issuecomment-1299102108 https://api.github.com/repos/simonw/datasette/issues/1879 IC_kwDOBm6k_c5Nbrmc simonw 9599 2022-11-01T20:30:54Z 2022-11-01T20:33:06Z OWNER

One idea: add a /-/debug page (or /-/tips or /-/checks) which shows the incoming requests headers and could even detect if there's an x-forwarded-host header that isn't being repeated and show a tip on how to fix that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it easier to fix URL proxy problems 1432037325  
1299102755 https://github.com/simonw/datasette/issues/1879#issuecomment-1299102755 https://api.github.com/repos/simonw/datasette/issues/1879 IC_kwDOBm6k_c5Nbrwj simonw 9599 2022-11-01T20:31:37Z 2022-11-01T20:31:37Z OWNER

And some JavaScript that can spot if Datasette thinks it is being served over HTTP when it's actually being served over HTTPS.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it easier to fix URL proxy problems 1432037325  
1299096850 https://github.com/simonw/datasette/issues/1879#issuecomment-1299096850 https://api.github.com/repos/simonw/datasette/issues/1879 IC_kwDOBm6k_c5NbqUS simonw 9599 2022-11-01T20:26:12Z 2022-11-01T20:26:12Z OWNER

The other relevant plugin here is https://datasette.io/plugins/datasette-x-forwarded-host

Maybe that should be rolled into core too?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it easier to fix URL proxy problems 1432037325  
1299090678 https://github.com/simonw/datasette/issues/1879#issuecomment-1299090678 https://api.github.com/repos/simonw/datasette/issues/1879 IC_kwDOBm6k_c5Nboz2 simonw 9599 2022-11-01T20:20:28Z 2022-11-01T20:20:28Z OWNER

My first step in debugging these is to install https://datasette.io/plugins/datasette-debug-asgi - but now I'm thinking maybe something like that should be part of core.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it easier to fix URL proxy problems 1432037325  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);